Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4857 +/- ##
=======================================
Coverage 73.85% 73.86%
=======================================
Files 483 483
Lines 17577 17577
Branches 3464 3464
=======================================
+ Hits 12982 12983 +1
Misses 3741 3741
+ Partials 854 853 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| Compression = (CompressionType)reader.ReadByte(); | ||
| var nameAsBytes = reader.ReadBytes(32); | ||
| Name = Encoding.UTF8.GetString(nameAsBytes.Reverse().SkipWhile(x => x == 0).Reverse().ToArray()); | ||
| Name = Encoding.UTF8.GetString(Enumerable.Reverse(nameAsBytes).SkipWhile(x => x == 0).Reverse().ToArray()); |
There was a problem hiding this comment.
note: other method bound with [Proposal]: First-Class Span Types
byte[] bytes = new byte[0];
_ = bytes.Reverse();now prefers public static void Reverse<T>(this Span<T> span) in System.MemoryExtensions (if available),
rather than public static IEnumerable<TSource> Reverse<TSource>(this TSource[] source) in System.Linq.Enumerable.
Invoking the LINQ extension method explicitly instead.
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Suggested adding one comment, but otherwise all good 👍🏻
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
2 participants
Upgrade to C# 14.0
See Language Feature Status.
Also a prerequisite to upgrade to the latest version of
Polyfill, after SimonCropp/Polyfill#454.